-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set accepted even if gateway could not be programmed and attach route to listener even if listener not ready #4987
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4987 +/- ##
=======================================
- Coverage 75.3% 73.1% -2.2%
=======================================
Files 167 167
Lines 18721 18843 +122
=======================================
- Hits 14104 13788 -316
- Misses 3790 4227 +437
- Partials 827 828 +1
☔ View full report in Codecov by Sentry. |
b0806c9
to
a144f68
Compare
GatewayWithAttachedRoutes
a144f68
to
e80ed59
Compare
The current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos
marked this as "do not merge" since the latest version of gateway API changed expected "Accepted" condition of tested |
6071601
to
b18f3e8
Compare
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
What this PR does / why we need it:
To pass the conformance test
GatewayWithAttachedRoutes
, the PR:Accepted
of listener to true even if the listener could not beProgrammed
Which issue this PR fixes:
fixes #4982
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR