tests: workaround docker bug affecting kongintegration flakiness #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
fix/flaky-kongintegration
branch
from
8d7b015
to
a310cf3
Compare
czeslavo
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5005 +/- ##
=======================================
- Coverage 75.4% 67.3% -8.1%
=======================================
Files 167 162 -5
Lines 18714 18571 -143
=======================================
- Hits 14113 12513 -1600
- Misses 3777 5301 +1524
+ Partials 824 757 -67 ☔ View full report in Codecov by Sentry. |
pmalek
reviewed
Oct 29, 2023
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
programmer04
requested changes
Oct 30, 2023
pmalek
reviewed
Oct 30, 2023
programmer04
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Docker's bug described in moby/moby#42442 causes
testcontainers-goused inkongintegrationtests to create containers with port mappings that may overlap if created at the same time by parallel test cases. This PR works this around by explicitly specifying host ports to be used.Which issue this PR fixes:
Should fix #4940.