-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use debug level for readiness checks logs #5029
Conversation
a6f623e
to
9f2b6c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's exactly like you described, calling Error
always overwrites the level to error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5029 +/- ##
=======================================
- Coverage 75.4% 75.2% -0.3%
=======================================
Files 167 167
Lines 18796 18796
=======================================
- Hits 14184 14144 -40
- Misses 3787 3830 +43
+ Partials 825 822 -3
☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.12.x release/2.12.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.12.x
# Create a new branch
git switch --create backport-5029-to-release/2.12.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 afe12ed7a15299de3343132002c2451fe8aa42cb
# Push it to GitHub
git push --set-upstream origin backport-5029-to-release/2.12.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.12.x Then, create a pull request where the |
(cherry picked from commit afe12ed)
What this PR does / why we need it:
It turns out
s.logger.V(util.DebugLevel).Error(err, "...")
doesn't result in a log message with a debug, but an error level. The PR fixes logs that were intended to use debug-level with the error as a log field.Which issue this PR fixes:
Customer reported
kind of logs presence repeating quite often. Error logs should not be used for that kind of message as they're signaling expected situations that users should not be worried about.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR