-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(logs): modifying the capitalization consistency of the logs #5033
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5033 +/- ##
=====================================
Coverage 75.5% 75.5%
=====================================
Files 167 167
Lines 18881 18881
=====================================
+ Hits 14262 14268 +6
+ Misses 3791 3788 -3
+ Partials 828 825 -3
☔ View full report in Codecov by Sentry. |
3de73c5
to
24f744d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to recommendation, error messages should not be capitalized. I did not comment on every place, but all messages in fmt.Errorf()
and errors.New()
should not be capitalized.
internal/admission/validation/consumers/credentials/validation.go
Outdated
Show resolved
Hide resolved
24f744d
to
4af8031
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I searched for log messages (by finding Info(...)
and Error(...)
calls) and found some log messages are not updated.
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
4af8031
to
5adc181
Compare
What this PR does / why we need it:
Which issue this PR fixes:
part of #3708
Special notes for your reviewer:
It has been split from PR #4992 to make it easier to review.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR