Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): modifying the capitalization consistency of the logs #5033

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

pangruoran
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes:
part of #3708

Special notes for your reviewer:

It has been split from PR #4992 to make it easier to review.
PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (62e6df8) 75.5% compared to head (5adc181) 75.5%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5033   +/-   ##
=====================================
  Coverage   75.5%   75.5%           
=====================================
  Files        167     167           
  Lines      18881   18881           
=====================================
+ Hits       14262   14268    +6     
+ Misses      3791    3788    -3     
+ Partials     828     825    -3     
Files Coverage Δ
internal/adminapi/backoff_strategy_konnect.go 100.0% <100.0%> (ø)
internal/clients/readiness.go 89.1% <100.0%> (ø)
...ntrollers/configuration/kongadminapi_controller.go 61.4% <100.0%> (ø)
...nal/controllers/gateway/gatewayclass_controller.go 79.2% <100.0%> (ø)
internal/dataplane/sendconfig/sendconfig.go 82.4% <83.3%> (ø)
internal/manager/run.go 54.9% <83.3%> (ø)
internal/controllers/gateway/gateway_controller.go 72.7% <66.6%> (-0.2%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pangruoran pangruoran marked this pull request as ready for review October 31, 2023 15:29
@pangruoran pangruoran requested a review from a team as a code owner October 31, 2023 15:29
pmalek
pmalek previously requested changes Oct 31, 2023
internal/adminapi/backoff_strategy_konnect_test.go Outdated Show resolved Hide resolved
internal/adminapi/endpoints.go Outdated Show resolved Hide resolved
internal/adminapi/kong.go Outdated Show resolved Hide resolved
Copy link
Contributor

@randmonkey randmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to recommendation, error messages should not be capitalized. I did not comment on every place, but all messages in fmt.Errorf() and errors.New() should not be capitalized.

internal/adminapi/client.go Outdated Show resolved Hide resolved
internal/adminapi/endpoints.go Outdated Show resolved Hide resolved
internal/adminapi/kong.go Outdated Show resolved Hide resolved
internal/adminapi/kong.go Outdated Show resolved Hide resolved
Copy link
Contributor

@randmonkey randmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched for log messages (by finding Info(...) and Error(...) calls) and found some log messages are not updated.

internal/clients/readiness.go Show resolved Hide resolved
internal/dataplane/sendconfig/sendconfig.go Show resolved Hide resolved
internal/manager/run.go Show resolved Hide resolved
@pangruoran pangruoran enabled auto-merge (squash) November 1, 2023 08:56
@pangruoran pangruoran merged commit c44cb7b into main Nov 2, 2023
45 checks passed
@pangruoran pangruoran deleted the unified-log-case-part1 branch November 2, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants