fix: remove HTTP ports from discovery config #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the HTTP port names from the default list of accepted Service ports for discovery. Discovery is hard-coded to support HTTPS only, and would unsuccessfully attempt to use HTTP ports when available. In DB mode this could prevent the controller from talking to Kong at all if it chose an HTTP port from the list.
rainest
force-pushed
the
chore/admin-svc-names
branch
from
82b86a5
to
f65e408
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5043 +/- ##
=======================================
+ Coverage 75.4% 75.6% +0.1%
=======================================
Files 167 167
Lines 18881 18881
=======================================
+ Hits 14253 14276 +23
+ Misses 3796 3781 -15
+ Partials 832 824 -8
☔ View full report in Codecov by Sentry. |
pangruoran
approved these changes
Nov 1, 2023
czeslavo
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove the HTTP port names from the default list of accepted Service ports for discovery.
Which issue this PR fixes:
Discovery is hard-coded to support HTTPS only, and would unsuccessfully attempt to use HTTP ports when available. The client generator code builds clients for all admissable port names and has no filters by protocol.
In DB mode this could prevent the controller from talking to Kong at all if it chose an HTTP port from the list, as it only selects a single client from the list (at least as of the current draft in #4828).
Special notes for your reviewer:
AFAIK there should not be any reason to add HTTP support for discovery. I had only been using it to simplify manual requests in a debugging session.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR