-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate configPatches for KongClusterPlugin #5208
fix: validate configPatches for KongClusterPlugin #5208
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5208 +/- ##
=======================================
- Coverage 76.8% 76.8% -0.1%
=======================================
Files 170 170
Lines 19050 19056 +6
=======================================
- Hits 14649 14648 -1
- Misses 3575 3578 +3
- Partials 826 830 +4 ☔ View full report in Codecov by Sentry. |
I'd say we just skip the changelog entry in such cases. 👍 |
How about adding a link to this PR under the original entry? |
Yeah, it can work as well 👍 |
Found that we did not include tests on validation webhook of plugins ( |
+1 for a separate issue. |
What this PR does / why we need it:
KongClusterPlugin
to generate configuration usingconfigPatches
ValidateKongPlugin
inValidateKongClusterPlugin
Which issue this PR fixes:
fixes the problem of validator for
KongClusterPlugin
in #5158.Special notes for your reviewer:
REVIEW: how do we write changelog here? This is a fix on a not yet released feature.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR