feat: set KongServiceFacade's Programmed condition #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
feat/service-facade-programmed-cond
branch
from
c4e5588
to
eef6343
Compare
czeslavo
force-pushed
the
feat/service-facade-programmed-cond
branch
from
eef6343
to
08c090d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5290 +/- ##
=======================================
+ Coverage 75.6% 75.8% +0.2%
=======================================
Files 170 170
Lines 19457 19450 -7
=======================================
+ Hits 14714 14748 +34
+ Misses 3912 3869 -43
- Partials 831 833 +2 ☔ View full report in Codecov by Sentry. |
programmer04
reviewed
Dec 5, 2023
programmer04
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Propagates
KongServiceFacadeto thetranslatedObjectsCollectorin theTranslatorso that itsProgrammedcondition is properly set.Which issue this PR fixes:
Part of #5152.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR