feat: rename incubator package to incubator.ingress-controller.konghq.com #5302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
changed the title
czeslavo
changed the title
czeslavo
changed the title
czeslavo
force-pushed
the
feat/change-incubator-package-name
branch
from
5af33ee
to
243166d
Compare
czeslavo
force-pushed
the
feat/change-incubator-package-name
branch
from
243166d
to
8ae138b
Compare
1 task
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5302 +/- ##
=======================================
+ Coverage 75.7% 75.9% +0.1%
=======================================
Files 170 170
Lines 19457 19458 +1
=======================================
+ Hits 14742 14770 +28
+ Misses 3879 3858 -21
+ Partials 836 830 -6 ☔ View full report in Codecov by Sentry. |
rainest
approved these changes
Dec 7, 2023
4 tasks
czeslavo
added a commit
to Kong/charts
that referenced
this pull request
Dec 7, 2023
Aligns the API group name for KongServiceFacade RBAC rules so it matches after the rename Kong/kubernetes-ingress-controller#5302. Releases a kong/kong 2.33.1 patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After a discussion regarding package naming, we've decided to use a better-namespaced pattern for new packages. In
configuration.konghq.comwe lacked a part that would namespace our packages specifically to KIC which is not perfect as that would be better to keep our APIs in Kong to be consistently namespaced. In KGO we've used*.gateway-operator.konghq.compattern so usingincubator.ingress-controller.konghq.comin KIC is consistent with that and the pattern we'd like to follow in the future is<component-local-package-name>.<component-name>.konghq.com.Which issue this PR fixes:
Part of #5152.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR