feat: add KongVault CRD #5354
Merged
feat: add KongVault CRD #5354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5354 +/- ##
=======================================
+ Coverage 69.6% 71.4% +1.7%
=======================================
Files 174 174
Lines 21934 21934
=======================================
+ Hits 15278 15672 +394
+ Misses 5765 5353 -412
- Partials 891 909 +18 ☔ View full report in Codecov by Sentry. |
randmonkey
force-pushed
the
feat/define_kongVault_crd
branch
from
fb412ed
to
55f7f85
Compare
randmonkey
added
area/feature
randmonkey
force-pushed
the
feat/define_kongVault_crd
branch
2 times, most recently
from
d42f3f6
to
2d880d3
Compare
programmer04
requested changes
Dec 18, 2023
programmer04
previously approved these changes
Dec 18, 2023
czeslavo
reviewed
Dec 18, 2023
czeslavo
reviewed
Dec 18, 2023
randmonkey
force-pushed
the
feat/define_kongVault_crd
branch
from
83e0d90
to
eb7e012
Compare
tao12345666333
approved these changes
Dec 26, 2023
pmalek
reviewed
Jan 2, 2024
| @@ -129,6 +129,9 @@ Adding a new version? You'll need three changes: | |||
| - Added functionality to the `KongUpstreamPolicy` controller to properly set and | |||
| enforce `KongUpstreamPolicy` status. | |||
| [#5185](https://github.com/Kong/kubernetes-ingress-controller/pull/5185) | |||
| - Add CRD `KongVault` to reperesent a custom Kong vault for storing senstive | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add definition of
KongVaultCRD to define a custom Kong vault.Which issue this PR fixes:
fixes #5332, and part of #4559.
Special notes for your reviewer:
backendandprefixin the spec?backendonly supports several values (env,aws,azure,gcp,hcv) but possible to add new backends. So we only limit it to be non-empty, and let the webhook to call validation API on Kong gateway side.prefixshould be unique, but I did not find an annotation to tell the APIserver that a field is UNIQUE. So we also have to validate it in webhooks.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR