Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement controller and translator for KongVault #5384

Merged
merged 9 commits into from
Jan 8, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Dec 27, 2023

What this PR does / why we need it:

Implement the controller and the translator of KongVault to generate and configuration of custom vaults.

Which issue this PR fixes:

Major part of #5333.

Special notes for your reviewer:

Although the controller is not fully completed yet, to avoid the PR being too large to review, please review it and do not require a significant change on this PR.
Remaining parts:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner December 27, 2023 08:26
@randmonkey randmonkey marked this pull request as draft December 27, 2023 08:26
@randmonkey randmonkey added area/feature New feature or request work in progress Work In Progress labels Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 123 lines in your changes are missing coverage. Please review.

Comparison is base (558dd93) 69.5% compared to head (88cf36e) 69.4%.
Report is 7 commits behind head on main.

Files Patch % Lines
...trollers/configuration/zz_generated_controllers.go 45.7% 55 Missing and 9 partials ⚠️
internal/admission/handler.go 0.0% 13 Missing ⚠️
internal/dataplane/kongstate/kongstate.go 61.5% 7 Missing and 3 partials ⚠️
internal/admission/validator.go 74.2% 6 Missing and 3 partials ⚠️
internal/store/store.go 47.0% 9 Missing ⚠️
internal/admission/adminapi_provider.go 0.0% 6 Missing ⚠️
internal/store/fake_store.go 44.4% 4 Missing and 1 partial ⚠️
internal/store/cache_stores.go 42.8% 4 Missing ⚠️
internal/dataplane/deckgen/generate.go 66.6% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5384     +/-   ##
=======================================
- Coverage   69.5%   69.4%   -0.2%     
=======================================
  Files        174     174             
  Lines      21934   22192    +258     
=======================================
+ Hits       15258   15402    +144     
- Misses      5780    5880    +100     
- Partials     896     910     +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey force-pushed the feat/kong_vault_controller branch 3 times, most recently from af699cd to 51b2130 Compare December 28, 2023 08:05
@randmonkey randmonkey force-pushed the feat/kong_vault_controller branch 2 times, most recently from b2f1092 to b5effab Compare December 29, 2023 09:10
@randmonkey randmonkey marked this pull request as ready for review January 4, 2024 06:09
@randmonkey randmonkey changed the title [WIP] Implement controller and translator for KongVault Implement controller and translator for KongVault Jan 4, 2024
@randmonkey randmonkey removed the work in progress Work In Progress label Jan 4, 2024
Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, since this is called out as incomplete, what are the specific remaining tasks? We should always try to mention those since reviewers won't inherently have that context, and can't accurately gauge whether a partial implementation will be compatible with the assumed future next steps.

internal/admission/validator.go Outdated Show resolved Hide resolved
internal/admission/errors.go Outdated Show resolved Hide resolved
internal/dataplane/failures/failures.go Outdated Show resolved Hide resolved
internal/dataplane/failures/failures_test.go Outdated Show resolved Hide resolved
internal/dataplane/kongstate/plugin.go Outdated Show resolved Hide resolved
internal/dataplane/translator/translator.go Outdated Show resolved Hide resolved
@randmonkey
Copy link
Contributor Author

For posterity, since this is called out as incomplete, what are the specific remaining tasks? We should always try to mention those since reviewers won't inherently have that context, and can't accurately gauge whether a partial implementation will be compatible with the assumed future next steps.

Updated the comments on the PR and listed the follow up things after this PR.

@rainest rainest merged commit 01a2093 into main Jan 8, 2024
37 checks passed
@rainest rainest deleted the feat/kong_vault_controller branch January 8, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants