Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add workspace in FillIDs #5401

Merged
merged 5 commits into from
Jan 10, 2024
Merged

fix: add workspace in FillIDs #5401

merged 5 commits into from
Jan 10, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jan 5, 2024

What this PR does / why we need it:

Add the workspace parameter in filling IDs of Kong entities to avoid generating the same ID for entities with same "key" (like username in consumers) in different workspaces.

Which issue this PR fixes:

Fixes #5389

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner January 5, 2024 07:09
@randmonkey randmonkey self-assigned this Jan 5, 2024
@randmonkey randmonkey added this to the KIC v3.1.x milestone Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (81d9d41) 69.3% compared to head (b55166a) 69.2%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/dataplane/kongstate/kongstate.go 33.3% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5401     +/-   ##
=======================================
- Coverage   69.3%   69.2%   -0.1%     
=======================================
  Files        176     176             
  Lines      22355   22358      +3     
=======================================
- Hits       15497   15487     -10     
- Misses      5932    5940      +8     
- Partials     926     931      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
internal/dataplane/kongstate/kongstate.go Show resolved Hide resolved
@randmonkey randmonkey closed this Jan 9, 2024
@randmonkey randmonkey reopened this Jan 9, 2024
@randmonkey randmonkey merged commit 0314607 into main Jan 10, 2024
37 checks passed
@randmonkey randmonkey deleted the fix/add_workspace_in_fill_id branch January 10, 2024 08:54
@rainest rainest mentioned this pull request Mar 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting in KIC 3.0.x, Same-named Entities in Multiple Workspaces Results in Collisions
3 participants