Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new flag to reconcile one specific Gateway only #5405

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat: add new flag to reconcile one specific Gateway only #5405

merged 1 commit into from
Jan 17, 2024

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Jan 5, 2024 •
edited

What this PR does / why we need it:

Which issue this PR fixes:

fixes: #5322
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d5f068d) 69.6% compared to head (1e33cc3) 69.5%.
Report is 2 commits behind head on main.

❗ Current head 1e33cc3 differs from pull request most recent head 1f93364. Consider uploading reports for the commit 1f93364 to get more accurate results

Files Patch % Lines
...ternal/controllers/gateway/grpcroute_controller.go 90.0% 1 Missing ⚠️
...nternal/controllers/gateway/udproute_controller.go 90.0% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #5405     +/-   ##
=======================================
- Coverage   69.6%   69.5%   -0.1%     
=======================================
  Files        176     176             
  Lines      22554   22620     +66     
=======================================
+ Hits       15700   15742     +42     
- Misses      5925    5943     +18     
- Partials     929     935      +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/XS labels Jan 9, 2024
@tao12345666333 tao12345666333 force-pushed the feat/specific-gw branch 2 times, most recently from 6ea9e43 to 93e1868 Compare January 10, 2024 06:04
@tao12345666333 tao12345666333 added this to the KIC v3.1.x milestone Jan 10, 2024
@tao12345666333 tao12345666333 self-assigned this Jan 10, 2024
@tao12345666333 tao12345666333 force-pushed the feat/specific-gw branch 2 times, most recently from d1578fd to 8712177 Compare January 15, 2024 07:41
@tao12345666333 tao12345666333 marked this pull request as ready for review January 15, 2024 07:41
@tao12345666333 tao12345666333 requested a review from a team as a code owner January 15, 2024 07:41
czeslavo
czeslavo requested changes Jan 15, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
internal/manager/config.go Show resolved Hide resolved
internal/manager/config.go Outdated Show resolved Hide resolved
internal/manager/config_validation.go Outdated Show resolved Hide resolved
internal/manager/config.go Outdated Show resolved Hide resolved
internal/controllers/gateway/httproute_controller.go Outdated Show resolved Hide resolved
internal/controllers/gateway/tcproute_controller.go Outdated Show resolved Hide resolved
internal/controllers/gateway/tlsroute_controller.go Outdated Show resolved Hide resolved
internal/controllers/gateway/udproute_controller.go Outdated Show resolved Hide resolved
internal/controllers/gateway/grpcroute_controller.go Outdated Show resolved Hide resolved
@czeslavo
Copy link
Contributor

I think we could consider making the flag name more descriptive so that instead of gateway-namespaced-name we'd have e.g. gateway-to-reconcile or only-reconcile-gateway.

@tao12345666333
Copy link
Member Author

I will change the name to gateway-to-reconcile, thanks

@tao12345666333 tao12345666333 force-pushed the feat/specific-gw branch 3 times, most recently from 4f9d5c6 to 5cbb8ba Compare January 17, 2024 02:23
randmonkey
randmonkey reviewed Jan 17, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
internal/controllers/gateway/grpcroute_controller.go Outdated Show resolved Hide resolved
internal/controllers/gateway/grpcroute_controller.go Outdated Show resolved Hide resolved
internal/controllers/gateway/route_utils.go Outdated Show resolved Hide resolved
internal/controllers/gateway/tcproute_controller.go Outdated Show resolved Hide resolved
internal/controllers/gateway/tcproute_controller.go Outdated Show resolved Hide resolved
internal/controllers/gateway/tlsroute_controller.go Outdated Show resolved Hide resolved
internal/manager/config.go Outdated Show resolved Hide resolved
randmonkey
randmonkey previously approved these changes Jan 17, 2024
View reviewed changes
czeslavo
czeslavo previously approved these changes Jan 17, 2024
View reviewed changes
@tao12345666333 tao12345666333 enabled auto-merge (squash) January 17, 2024 09:16
@tao12345666333 @czeslavo @randmonkey
feat: add new flag to specific Gateway
1f93364 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>

Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
Co-authored-by: Tao Yi  <tao.yi@konghq.com>
@tao12345666333 tao12345666333 merged commit 2e22a10 into main Jan 17, 2024
35 checks passed
@tao12345666333 tao12345666333 deleted the feat/specific-gw branch January 17, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czeslavo czeslavo czeslavo approved these changes

@randmonkey randmonkey randmonkey left review comments

Assignees

@tao12345666333 tao12345666333

Labels
size/L
Projects
None yet
Milestone
KIC v3.1.x
Development

Successfully merging this pull request may close these issues.

Add flags to reconcile one specific Gateway only
3 participants
@tao12345666333 @czeslavo @randmonkey