feat: add uniqueness check of spec.prefix of KongVault #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5412 +/- ##
=======================================
+ Coverage 69.6% 69.7% +0.1%
=======================================
Files 176 176
Lines 22554 22565 +11
=======================================
+ Hits 15700 15734 +34
+ Misses 5925 5904 -21
+ Partials 929 927 -2 ☔ View full report in Codecov by Sentry. |
randmonkey
force-pushed
the
feat/validate_vault_prefix_uniqueness
branch
from
eaf998b
to
d1f8549
Compare
pmalek
reviewed
Jan 9, 2024
randmonkey
force-pushed
the
feat/validate_vault_prefix_uniqueness
branch
2 times, most recently
from
cac7cab
to
793a1eb
Compare
randmonkey
force-pushed
the
feat/validate_vault_prefix_uniqueness
branch
from
6370651
to
93c2913
Compare
czeslavo
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Check uniqueness of
spec.prefixofKongVaultin all "managed" KongVaults by listing all items in the storer.Which issue this PR fixes:
fixes #5395
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR