fix: remove stale parent statuses from HTTPRoute #5477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5477 +/- ##
=====================================
Coverage 69.7% 69.8%
=====================================
Files 176 176
Lines 22726 22786 +60
=====================================
+ Hits 15852 15905 +53
- Misses 5933 5941 +8
+ Partials 941 940 -1 ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
fix/remove-old-parent-status
branch
from
908cbbc
to
ea1ebbc
Compare
czeslavo
changed the title
czeslavo
force-pushed
the
fix/remove-old-parent-status
branch
from
ea1ebbc
to
bd2d796
Compare
czeslavo
removed
the
do not merge
rainest
requested changes
Jan 25, 2024
rainest
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It ensures we leave no stale parent statuses in
HTTPRoutes (e.g. after moving a route from one Gateway to another by changing itsspec.parentRefs).Which issue this PR fixes:
Fixes #5277.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR