feat: sanitize plugins configuration built from secrets #5495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
feat/sanitize-plugins-config
branch
2 times, most recently
from
ae45dd8
to
b7427aa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5495 +/- ##
=======================================
- Coverage 69.8% 69.8% -0.1%
=======================================
Files 176 176
Lines 22792 22857 +65
=======================================
+ Hits 15919 15959 +40
- Misses 5935 5956 +21
- Partials 938 942 +4 ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
feat/sanitize-plugins-config
branch
4 times, most recently
from
74e50f4
to
92a28cf
Compare
programmer04
previously approved these changes
Jan 29, 2024
czeslavo
force-pushed
the
feat/sanitize-plugins-config
branch
from
92a28cf
to
db23b87
Compare
programmer04
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It introduces data sanitization for plugins' configuration when it is sourced from Secrets.
Which issue this PR fixes:
Part of #5467.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR