Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't populate fields disallowed for expressions router in Konnect #5581

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Feb 7, 2024

What this PR does / why we need it:

Bump go-database-reconciler to a version that fixes the issue with populating regex_priority and path_handling for expression routes. Starts running kongintegration tests against Konnect with all golden tests outputs (including the ones with expressions router which were disabled before).

Which issue this PR fixes:

Fixes #5148.

Special notes for your reviewer:

It's fixed thanks to the changes in go-database-reconciler: Kong/go-database-reconciler#55
PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28e0f84) 71.7% compared to head (f0b0198) 71.7%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5581     +/-   ##
=======================================
- Coverage   71.7%   71.7%   -0.1%     
=======================================
  Files        177     177             
  Lines      18301   18301             
=======================================
- Hits       13138   13137      -1     
  Misses      4201    4201             
- Partials     962     963      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo added this to the KIC v3.1.x milestone Feb 7, 2024
@czeslavo czeslavo marked this pull request as ready for review February 7, 2024 10:03
@czeslavo czeslavo requested a review from a team as a code owner February 7, 2024 10:03
@czeslavo czeslavo enabled auto-merge (squash) February 7, 2024 10:07
@czeslavo czeslavo merged commit 09a8257 into main Feb 7, 2024
38 checks passed
@czeslavo czeslavo deleted the fix-konnect-expressions branch February 7, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When expression router enabled, KIC fails to send configurations to Konnect
2 participants