support license with DB backed Kong gateways #5648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5648 +/- ##
=======================================
+ Coverage 73.8% 74.0% +0.1%
=======================================
Files 176 176
Lines 18210 18212 +2
=======================================
+ Hits 13455 13478 +23
+ Misses 3753 3734 -19
+ Partials 1002 1000 -2 ☔ View full report in Codecov by Sentry. |
randmonkey
force-pushed
the
fix/support_license_in_postgres
branch
2 times, most recently
from
e399849
to
5846c2f
Compare
randmonkey
force-pushed
the
fix/support_license_in_postgres
branch
3 times, most recently
from
a28d3ab
to
6059008
Compare
randmonkey
force-pushed
the
fix/support_license_in_postgres
branch
from
6059008
to
16139ec
Compare
randmonkey
force-pushed
the
fix/support_license_in_postgres
branch
from
16139ec
to
b231646
Compare
programmer04
reviewed
Apr 8, 2024
programmer04
approved these changes
Apr 8, 2024
|
When will this finally be released? |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.1.x release/3.1.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.1.x
# Create a new branch
git switch --create backport-5648-to-release/3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 431a5bc44b8fcb5be448846a8687f7a5d5c4fe3b
# Push it to GitHub
git push --set-upstream origin backport-5648-to-release/3.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.1.xThen, create a pull request where the |
randmonkey
added a commit
that referenced
this pull request
May 9, 2024
* update gdr * enable license test when db backed * run go mod tidy and update ut * set IncludeLicense to true * update gdr * update dumpConfig and update CHANGELOG (cherry picked from commit 431a5bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bump go-database-reconciler to enable sync of licenses with DB backed Kong gateways.
Also enables the test on licenses in isolated integration tests.
Which issue this PR fixes:
fixes #5644
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR