feat: managed gateways config pushed when accepted #5662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5662 +/- ##
=======================================
- Coverage 71.7% 71.6% -0.1%
=======================================
Files 176 176
Lines 18164 18163 -1
=======================================
- Hits 13038 13022 -16
- Misses 4177 4183 +6
- Partials 949 958 +9 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
mlavacca
force-pushed
the
mlavacca/managed-gateways
branch
from
993baff
to
cc50b1a
Compare
rainest
approved these changes
Feb 27, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.1.x release/3.1.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.1.x
# Create a new branch
git switch --create backport-5662-to-release/3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0d757a0f2895665655c034a80c7d9e16c2b8855c
# Push it to GitHub
git push --set-upstream origin backport-5662-to-release/3.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.1.xThen, create a pull request where the |
mlavacca
added a commit
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
mlavacca
added a commit
that referenced
this pull request
Feb 28, 2024
* feat: managed gateways config pushed when accepted (#5662) Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> * fix(controllers) skip routes bound to excluded GWs (#5642) In single-Gateway mode, properly skip route parent references for other Gateways when determining whether to include a route. * chore: generate validating webhook config using controller-gen (#5659) * tests: port KongVault validation webhook tests to envtests (#5605) Co-authored-by: Patryk Małek <patryk.malek@konghq.com> --------- Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> Co-authored-by: Travis Raines <571832+rainest@users.noreply.github.com> Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
mlavacca
added a commit
that referenced
this pull request
Feb 29, 2024
* feat: managed gateways config pushed when accepted (#5662) Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> * fix(controllers) skip routes bound to excluded GWs (#5642) In single-Gateway mode, properly skip route parent references for other Gateways when determining whether to include a route. * chore: generate validating webhook config using controller-gen (#5659) * tests: port KongVault validation webhook tests to envtests (#5605) Co-authored-by: Patryk Małek <patryk.malek@konghq.com> --------- Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com> Co-authored-by: Travis Raines <571832+rainest@users.noreply.github.com> Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
All the gateways (managed and unmanaged) are pushed to the dataplane. The condition for it is to have them accepted.
Which issue this PR fixes:
Fixes: #5600
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR