Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement rewrite path prefix filter for HTTPRoute in traditional router mode #5895

Merged
merged 17 commits into from
May 6, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Apr 19, 2024

What this PR does / why we need it:

Implements HTTPRoute's URLRewrite filter with path type ReplacePrefixMatch for the traditional router. Enables SupportHTTPRoutePathRewrite feature in Gateway API conformance tests.

Support for expressions router will be implemented in a separate PR.

Which issue this PR fixes:

Part of #3686.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo self-assigned this Apr 19, 2024
@czeslavo czeslavo force-pushed the feat/url-path-rewrite-httproute branch from 074427f to 7e55454 Compare April 23, 2024 12:20
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 84.44444% with 21 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@feb2ce1). Click here to learn what that means.
Report is 3 commits behind head on main.

❗ Current head 7c6e3a0 differs from pull request most recent head 4566bd1. Consider uploading reports for the commit 4566bd1 to get more accurate results

Files Patch % Lines
...al/dataplane/translator/subtranslator/httproute.go 85.7% 11 Missing and 6 partials ⚠️
...ataplane/translator/subtranslator/httproute_atc.go 50.0% 0 Missing and 2 partials ⚠️
...ternal/dataplane/translator/translate_httproute.go 83.3% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main   #5895   +/-   ##
======================================
  Coverage        ?   74.2%           
======================================
  Files           ?     179           
  Lines           ?   18377           
  Branches        ?       0           
======================================
  Hits            ?   13654           
  Misses          ?    3725           
  Partials        ?     998           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo force-pushed the feat/url-path-rewrite-httproute branch 7 times, most recently from 7a6f49d to 4e50224 Compare April 24, 2024 13:33
@czeslavo czeslavo added area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API area/feature New feature or request labels Apr 24, 2024
@czeslavo czeslavo added this to the KIC v3.2.x milestone Apr 24, 2024
@czeslavo czeslavo marked this pull request as ready for review April 24, 2024 16:31
@czeslavo czeslavo requested a review from a team as a code owner April 24, 2024 16:31
@czeslavo czeslavo force-pushed the feat/url-path-rewrite-httproute branch from 8cdbbea to 497da9c Compare April 24, 2024 16:38
@czeslavo czeslavo force-pushed the feat/url-path-rewrite-httproute branch from 497da9c to 5e090f0 Compare April 26, 2024 08:20
czeslavo and others added 2 commits April 26, 2024 12:19
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
…write-path-prefix/in.yaml

Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
@czeslavo czeslavo merged commit 5687b74 into main May 6, 2024
36 checks passed
@czeslavo czeslavo deleted the feat/url-path-rewrite-httproute branch May 6, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants