Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep): group update k8s.io to v0.30.0 and controller-runtime to v0.18.2 #5935

Merged
merged 5 commits into from May 10, 2024

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Apr 25, 2024

What this PR does / why we need it:

  • bump client-go to v0.30.0
  • bump controller-runtime to v0.18.0

Which issue this PR fixes:

Special notes for your reviewer:

Q: Why bump controller-runtime to v0.18.x in this PR?
A: ref: kubernetes-sigs/controller-runtime#2788 If we bump client-go to v0.30.0, it will cause go vet error.

Q: Why change it to Builder-style instead of using the Typed-handler?
A: As Typed Handlers are marked as experimental, I do not want to introduce experimental features into KIC at this time.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

- [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@tao12345666333 tao12345666333 added the dependencies Pull requests that update a dependency file label Apr 25, 2024
@tao12345666333 tao12345666333 self-assigned this Apr 25, 2024
@tao12345666333 tao12345666333 added this to the KIC v3.2.x milestone Apr 25, 2024
@tao12345666333 tao12345666333 changed the title chore(dep): group update k8s.io to v0.30.0 chore(dep): group update k8s.io to v0.30.0 and controller-runtime to v0.18.2 May 7, 2024
… v0.18.2

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 98.25436% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 74.0%. Comparing base (062684c) to head (5546d9f).
Report is 6 commits behind head on main.

❗ Current head 5546d9f differs from pull request most recent head 4255e66. Consider uploading reports for the commit 4255e66 to get more accurate results

Files Patch % Lines
internal/controllers/gateway/gateway_controller.go 81.8% 1 Missing and 1 partial ⚠️
...ternal/controllers/gateway/grpcroute_controller.go 95.4% 1 Missing ⚠️
...ternal/controllers/gateway/httproute_controller.go 96.0% 1 Missing ⚠️
...nternal/controllers/gateway/tcproute_controller.go 95.4% 1 Missing ⚠️
...nternal/controllers/gateway/tlsroute_controller.go 95.4% 1 Missing ⚠️
...nternal/controllers/gateway/udproute_controller.go 95.4% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5935     +/-   ##
=======================================
+ Coverage   72.3%   74.0%   +1.6%     
=======================================
  Files        181     182      +1     
  Lines      18473   18344    -129     
=======================================
+ Hits       13363   13580    +217     
+ Misses      4115    3826    -289     
+ Partials     995     938     -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 marked this pull request as ready for review May 10, 2024 11:02
@tao12345666333 tao12345666333 requested a review from a team as a code owner May 10, 2024 11:02
@tao12345666333 tao12345666333 mentioned this pull request May 10, 2024
4 tasks
@tao12345666333 tao12345666333 enabled auto-merge (squash) May 10, 2024 11:06
@tao12345666333 tao12345666333 merged commit 3017d33 into main May 10, 2024
37 checks passed
@tao12345666333 tao12345666333 deleted the dep-client-go-v0.30 branch May 10, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants