feat: implement rewrite path prefix filter for HTTPRoute in expressions router mode #5940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
added
the
area/gateway-api
czeslavo
force-pushed
the
feat/url-path-rewrite-expressions
branch
2 times, most recently
from
08712b3
to
60e7b41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5940 +/- ##
=======================================
+ Coverage 72.3% 74.0% +1.7%
=======================================
Files 179 179
Lines 18382 18393 +11
=======================================
+ Hits 13294 13624 +330
+ Misses 4108 3754 -354
- Partials 980 1015 +35 ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
feat/url-path-rewrite-expressions
branch
from
60e7b41
to
b277fc5
Compare
czeslavo
force-pushed
the
feat/url-path-rewrite-expressions
branch
from
b277fc5
to
794ddfc
Compare
czeslavo
force-pushed
the
feat/url-path-rewrite-expressions
branch
from
794ddfc
to
7090f7b
Compare
rainest
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Extends HTTPRoute's
URLRewritefilter with path typeReplacePrefixMatchsupport to theexpressionsrouter. AddsSupportHTTPRoutePathRewritefeature to the Gateway API conformance tests forexpressionsrouter.Which issue this PR fixes:
Part of #3686.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR