-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scaffold config dependency graph implementation #6010
Conversation
08637d6
to
b1789fa
Compare
13f5964
to
89cc2d8
Compare
418561c
to
0088c60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definite change request on the units having multiple expected children for one to many dependency relationships, maybe change request on the template approach.
If we do need templates: my kingdom for Github/editors having the ability to syntax highlight templated Go code and my not needing to copy it into something else and remove the string delimiters. How do we not have a
// syntaxhint:go
`// Code generated by hack/generators/config-graph; DO NOT EDIT.
package fallback
import (
"errors"
...
`
that understands "oh, Go with templating occasionally, use (mostly) Go syntax highlighting rules" instead of magic AI code writing assistants? I want to read code more quickly, not write code more quickly, damnit.
d3fc937
to
50a3c2b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6010 +/- ##
=======================================
+ Coverage 0 73.1% +73.1%
=======================================
Files 0 188 +188
Lines 0 18513 +18513
=======================================
+ Hits 0 13539 +13539
- Misses 0 4034 +4034
- Partials 0 940 +940 ☔ View full report in Codecov by Sentry. |
e665105
to
ed8b7a1
Compare
ed8b7a1
to
975ed51
Compare
975ed51
to
8df360c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we're clear here, approving without merging in case there's anything further @programmer04 wanted to wrap up in #6010 (comment)
What this PR does / why we need it:
Scaffolds code for building config dependency graph:
hack/generators/config-graph
code generator that outputsNewConfigGraphFromCacheStores
function ensuring that we include all objects from the store in the graphResolveDependencies
along with the internalresolveIngressDependencies
for Ingress - leaving the rest to be implemented in separate PR(s))Which issue this PR fixes:
Part of #5929.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR