chore: fix outdated TODO links #6050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
added
the
area/maintenance
czeslavo
force-pushed
the
chore/update-todo
branch
from
3dbc01e
to
433502f
Compare
programmer04
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes outdated TODO comments linking to already resolved issues:
HTTPRoutePathRewrite#3686HTTPRouteHostRewrite#3685ResolveDependenciesis implemented for all supported object types #6026Adds a unit test ensuring
filter.URLRewrite.Hostnamein HTTPRoute rule is allowed.Which issue this PR fixes:
Makes https://github.com/Kong/kubernetes-ingress-controller/actions/runs/9122991555/job/25084686979 green.