deploy: drop custom-server-block and use status_listen #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be merged after #633 |
rainest
requested changes
May 1, 2020
Comment on lines
+49
to
+50
| # - name: KONG_PROXY_ACCESS_LOG | ||
| # - value: /dev/stdout |
There was a problem hiding this comment.
Was commenting these intentional? It looks like this is unrelated.
There was a problem hiding this comment.
Yes, this is intentional.
Users when they are getting started can use this to log proxy access logs quickly.
hbagdi
force-pushed
the
deploy/status-listen
branch
from
daa2292
to
70d37d4
Compare
Until Kong 1.4, there didn't exist a way to health-check kong and expose metrics without also exposing the admin api of kong. In kong 1.4, a new server KONG_STATUS_LISTEN was added which provides these capabilities. This commit removes the reliance on the custom server block that was provided via a ConfigMap. With 0.9, the next version of controller, the minimum version of kong should be 1.4, hence this breaking change. The error logs have been modified as well to include proxy error logs as well.
hbagdi
force-pushed
the
deploy/status-listen
branch
from
70d37d4
to
8cd2781
Compare
rainest
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until Kong 1.4, there didn't exist a way to health-check kong and expose
metrics without also exposing the admin api of kong.
In kong 1.4, a new server KONG_STATUS_LISTEN was added which provides
these capabilities.
This commit removes the reliance on the custom server block that was
provided via a ConfigMap.
With 0.9, the next version of controller, the minimum version of kong
should be 1.4, hence this breaking change.
The error logs have been modified as well to include proxy error logs as
well.