feat(metrics): introduce metrics for everything from Gateway API #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
force-pushed
the
more-telemetry
branch
from
70cb680
to
6f88286
Compare
pmalek
reviewed
May 22, 2023
There was a problem hiding this comment.
We're at the stage of development in this repo that I believe some integration tests would be great to have.
What I suggest is to leverage envtest similarly as it's being done in https://github.com/Kong/kubernetes-ingress-controller/blob/b53c014c01e58f86e7c6254c4b3085670ab317e3/internal/adminapi/endpoints_envtest_test.go to spin up etcd and api-server, create those resources and assert that counters work.
Would you agree @programmer04? Do you mind creating such issue?
programmer04
force-pushed
the
more-telemetry
branch
from
6f88286
to
100d62a
Compare
pmalek
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KTF delegates the collection of metrics to this library, thus as described in this issue Kong/kubernetes-ingress-controller#3649 add providers to count all kinds that are in
gateway.networking.k8s.io. They will be introduced to KTF by bumping the used version of this pkg.