feat: detect if CRDs for GVRs are present before adding providers for them #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
detect-if-crds-for-GVRs-are-present
branch
from
caa1108
to
a7f0e7c
Compare
shaneutt
reviewed
Aug 17, 2022
pmalek
force-pushed
the
detect-if-crds-for-GVRs-are-present
branch
from
a7f0e7c
to
d7cca0f
Compare
shaneutt
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address #41. With this merged, the framework will be able to detect if a CRD for a particular GVR is available in the cluster before adding a provider (in this PR only
k8sObjectCountis affected) which would continuously return errors like these:due to resource not having a definition available in the cluster.