Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip e2es if no GOOGLE_APPLICATION_CREDENTIALS set #548

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Feb 7, 2023

Should solve #547.

@czeslavo czeslavo temporarily deployed to gcloud February 7, 2023 15:51 — with GitHub Actions Inactive
@czeslavo czeslavo marked this pull request as ready for review February 7, 2023 15:52
@czeslavo czeslavo requested review from a team and shaneutt as code owners February 7, 2023 15:52
@czeslavo czeslavo self-assigned this Feb 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Base: 53.73% // Head: 53.63% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (96f7ada) compared to base (5e7d22e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   53.73%   53.63%   -0.11%     
==========================================
  Files          50       50              
  Lines        3904     3904              
==========================================
- Hits         2098     2094       -4     
- Misses       1546     1550       +4     
  Partials      260      260              
Flag Coverage Δ
integration-test 58.58% <ø> (-0.12%) ⬇️
unit-test 3.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/clusters/utils.go 50.20% <0.00%> (-1.66%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo requested a review from pmalek February 7, 2023 15:59
@czeslavo czeslavo merged commit 471d07a into main Feb 7, 2023
@czeslavo czeslavo deleted the require-secrets-e2e branch February 7, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants