feat(k8s): Switch from CoreV1 Endpoints to DiscoveryV1 EndpointSlice #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 58.40% 58.53% +0.12%
==========================================
Files 43 43
Lines 3455 3461 +6
==========================================
+ Hits 2018 2026 +8
- Misses 1173 1174 +1
+ Partials 264 261 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
programmer04
force-pushed
the
switch-to-eps
branch
from
f63c56b
to
95ebe58
Compare
programmer04
force-pushed
the
switch-to-eps
branch
from
95ebe58
to
fd1ef3d
Compare
programmer04
force-pushed
the
switch-to-eps
branch
from
fd1ef3d
to
f6f4b12
Compare
3 tasks
pmalek
reviewed
May 9, 2023
programmer04
force-pushed
the
switch-to-eps
branch
from
820e9c1
to
68f9362
Compare
pmalek
reviewed
May 9, 2023
programmer04
force-pushed
the
switch-to-eps
branch
from
68f9362
to
2663eec
Compare
pmalek
approved these changes
May 9, 2023
programmer04
force-pushed
the
switch-to-eps
branch
from
2663eec
to
32b9c23
Compare
|
@programmer04 You'll need to re-push the commits after you've signed them |
programmer04
force-pushed
the
switch-to-eps
branch
from
32b9c23
to
37a0021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EndpointSlice API is available as V1 since K8s 1.21. Let's do not rely on old Endpoint API in KTF.
It's been spotted during work on Kong/kubernetes-ingress-controller#3916.
TestValidationWebhookfrom KIC usesWaitForConnectionOnServicePortfunction from KTF. When KIC dropsEndpointsin favour ofEndpointSlicethis test doesn't pass, becauseEndpointsare not created (and KTF expecting them).Mirroring works in other way from
EndpointstoEndpointSlicesunder circumstances described in docs. Thus after this change KTF should be still backward compatible withEndpointsand does not break someone's tests that rely on oldEndpoints.I've tested this change with KIC and everything passes
Endpointsand KTF withEndpointSliceEndpointSlice(WIP) and KTF withEndpointSliceThus this PR with high certainty (maybe some edge cases exist) shouldn't break someone's setup.
Other improvements - reduce coupling by replacing concrete K8s client as parameter with corresponding interface.