fix: correct ecs environment variable name

[windmgc]

Summary

I accidentally caught this by testing the lib in the ECS environment, logs show that

2022/09/22 08:19:18 [debug] 1#0: [lua] utils.lua:180: detect_region(): no AWS_REGION env variable
2022/09/22 08:19:18 [debug] 1#0: [lua] utils.lua:188: detect_region(): no AWS_DEFAULT_REGION env variable
2022/09/22 08:19:18 [debug] 1#0: [lua] utils.lua:201: detect_region(): no ECS_CONTAINERMETADATA_URI_V4 env variable
2022/09/22 08:19:18 [debug] 1#0: [lua] utils.lua:214: detect_region(): no ECS_CONTAINERMETADATA_URI env variable

The environment variable name for the ECS metadata URI seems to be wrong.

It should be ECS_CONTAINER_METADATA_URI and ECS_CONTAINER_METADATA_URI_V4, according to https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-metadata-endpoint-v4.html#task-metadata-endpoint-v4-paths and https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-metadata-endpoint-v3.html#task-metadata-endpoint-v3-paths

To keep all the references in the same format I also changed these variable names.

Changelog

• Correct ECS metadata URI environment variable name
• Update doc

[CLAassistant]

All committers have signed the CLA.

[Tieske]

can you please remove the documentation updates? the docs shouldn't be rendered on PR's because they go live immeditely after merging and then the docs are newer than the latest release. So only on a release render the docs. See instructions here: https://github.com/Kong/lua-resty-aws#history

[windmgc]

@Tieske got it, I've dropped the docs changes, please take a look again, thanks!

[Tieske]

Thx! good catch.

[Tieske]

version 0.5.5 is now up, including this fix.