Fix the issue: multi kong woker processes will premature trigger other woker processes's event callback #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses load targets, and trigger other workers's event callback, and result in the event_handler method error at line 925: the targets is nil when index it's ip field.
|
@hishamhm Hi, could you deal this pull request? |
hishamhm
requested changes
Apr 3, 2019
lib/resty/healthcheck.lua
Outdated
| @@ -1295,6 +1289,12 @@ function _M.new(opts) | |||
| if not ok then | |||
| self:log(ERR, "Error loading initial target list: ", err) | |||
| end | |||
|
|
|||
| self.ev_callback = function(data, event) | |||
There was a problem hiding this comment.
please fix the indentation on this line
|
@wuguangkuo Thanks for the patch! does this change alone fix the Kong issue? |
Yes, the error log was not appeared after this modification. |
|
@wuguangkuo Merged, thank you! |
|
I will push a patch release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue: When restart kong process, the concurrent worker processes load targets, and premature trigger other workers's event callback, and result in the event_handler method error at line 925: the targets is nil when index it's ip field. The issue I commited at "Kong" project: Kong/kong#4453