Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(healthcheck) fail hard when initial locking_target_list failed #34

Merged
merged 1 commit into from
Nov 14, 2019
Merged

fix(healthcheck) fail hard when initial locking_target_list failed #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/resty/healthcheck.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,9 @@ function _M.new(opts)
return true
end)
if not ok then
self:log(ERR, "Error loading initial target list: ", err)
-- locking failed, we don't protect `targets` of being nil in other places
-- so consider this as not recoverable
return nil, "Error loading initial target list: " .. err
end

self.ev_callback = function(data, event)
Expand Down