feat(healthcheck) support to mTLS in active checks #41
Conversation
| @@ -829,8 +830,16 @@ function checker:run_single_check(ip, port, hostname, hostheader) | |||
|
|
|||
| if self.checks.active.type == "https" then | |||
| local session | |||
| session, err = sock:sslhandshake(nil, hostname, | |||
| if self.ssl_cert and self.ssl_key then | |||
There was a problem hiding this comment.
It seems that we don't need to branch here, because the ssl_cert and ssl_key are always set together. If both are not set then the client cert is not used anyway. The call to sock:sslhandshake is unnecessary for the same reason.
There was a problem hiding this comment.
I think it's better to keep sock:sslhandshake as a backward compatibility, as sock:tlshandshake is not available when the certificate is invalid, like this: TEST 2: active probes, invalid cert
There was a problem hiding this comment.
Hmm, sock:tlshandshake should work with or without a valid certificate. Could you elaborate?
|
This seems to be going to |
This is the library |
No description provided.