chore(runtime) readjust cache dir for V8 runtime build #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reconciles the cache directory used by the "Setup cache" step in the ci.yml workflow with the one used by the `v8.sh` script. See #109.
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage 86.28% 86.28%
=======================================
Files 34 34
Lines 5426 5426
=======================================
Hits 4682 4682
Misses 744 744
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
thibaultcha
approved these changes
Jul 14, 2022
|
Ah, I should have left this in Draft status! I wanted to re-trigger its CI to make sure that it is caching V8 as expected this time, to make sure it's working before merging. Well, I guess we'll see once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reconciles the cache directory used by the "Setup cache" step in the ci.yml workflow with the one used by the
v8.shscript.See #109.