Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply encodeUrl only when body is passed. #133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prasad83
Copy link

@prasad83 prasad83 commented May 18, 2018

Query part can be constructed in the following manner into the URL:

  • $url . '?' . http_build_query($body); /* uses PHP_QUERY_RFC1738 */
  • $url . '?' . http_build_query($body, null, ini_get('arg_separator.output'), PHP_QUERY_RFC3986);

So when no $body is set - incoming $url should be assumed pre-built as required.

Query part can be constructed in the following manner into the URL:

* $url . '?' . http_build_query($data); /* uses PHP_QUERY_RFC1738 */
* $url . '?' . http_build_query($data, null, ini_get('arg_separator.output'), PHP_QUERY_RFC3986);

So when no $data is set - incoming $url should be assumed pre-built as required.
@prasad83 prasad83 changed the title Apply encodeUrl only when data is passed. Apply encodeUrl only when body is passed. May 18, 2018
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants