Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing figcaption editing #132

Merged
merged 13 commits into from Sep 25, 2023
Merged

Conversation

KonnorRogers
Copy link
Owner

@KonnorRogers KonnorRogers commented Sep 23, 2023

@lylo You totally nerd sniped me on this one. I caught so many issues with Attachments, Galleries, and caption editing. I think it's in a much better place now with this PR and it handles non-previewable assets much better now. This also normalizes white-space across figcaptions and fixes #131

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2023

🦋 Changeset detected

Latest commit: 063358d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
rhino-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rhino-editor ✅ Ready (Inspect) Visit Preview Sep 25, 2023 5:04am

@KonnorRogers KonnorRogers merged commit d760195 into main Sep 25, 2023
7 checks passed
@KonnorRogers KonnorRogers deleted the konnorrogers/fix-figcaption-spacing branch September 25, 2023 05:13
@github-actions github-actions bot mentioned this pull request Sep 25, 2023
@lylo
Copy link

lylo commented Sep 25, 2023

@KonnorRogers 😅 thank you for this! I will give it a whirl today 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants