Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

l500d: fix camera clicking/ticking noise when the device is idle. #1

Closed
wants to merge 1 commit into from
Closed

l500d: fix camera clicking/ticking noise when the device is idle. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions drivers/media/platform/msm/camera_v2/sensor/actuator/msm_actuator.c
View file
Open in desktop
Expand Up @@ -378,6 +378,12 @@ static int32_t msm_actuator_park_lens(struct msm_actuator_ctrl_t *a_ctrl)
uint16_t next_lens_pos = 0;
struct msm_camera_i2c_reg_setting reg_setting;

// msm8909: this case happens and prevents us from parking the lens
// if this adjustment is not made.
if (a_ctrl->park_lens.max_step == 0) {
a_ctrl->park_lens.max_step = a_ctrl->max_code_size;
}

a_ctrl->i2c_tbl_index = 0;
if ((a_ctrl->curr_step_pos > a_ctrl->total_steps) ||
(!a_ctrl->park_lens.max_step) ||
Expand Down Expand Up @@ -868,6 +874,15 @@ static int msm_actuator_close(struct v4l2_subdev *sd,
int rc = 0;
struct msm_actuator_ctrl_t *a_ctrl = v4l2_get_subdevdata(sd);
CDBG("Enter\n");

// make sure the lens is parked in case the userspace blobs
// don't call the proper ioctls.
if (a_ctrl->func_tbl && a_ctrl->func_tbl->actuator_park_lens)
rc = a_ctrl->func_tbl->actuator_park_lens(a_ctrl);
if (rc < 0) {
pr_err("%s: parking lens failed\n", __func__);
}

if (!a_ctrl) {
pr_err("failed\n");
return -EINVAL;
Expand Down