Fix broken bitshifts in GCC version of X86_Convert32To24 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berenm
pushed a commit
to bminor/SDL_mixer
that referenced
this pull request
Oct 2, 2020
Fixes broken bitshifts in libmodplug/src/fastmix.cpp:X86_Convert32To24()
SDL-mirror-bot
pushed a commit
to SDL-mirror/SDL_mixer
that referenced
this pull request
Oct 2, 2020
Fixes broken bitshifts in libmodplug/src/fastmix.cpp:X86_Convert32To24()
icculus
pushed a commit
to icculus/SDL_sound
that referenced
this pull request
Jun 28, 2021
icculus
pushed a commit
to icculus/SDL_sound
that referenced
this pull request
Jun 28, 2021
icculus
pushed a commit
to icculus/SDL_sound
that referenced
this pull request
Jun 28, 2021
icculus
pushed a commit
to icculus/SDL_sound
that referenced
this pull request
Jun 28, 2021
Wolf3s
pushed a commit
to Wolf3s/PS2SDL_mixer-1.2.12
that referenced
this pull request
Mar 30, 2024
Fixes broken bitshifts in libmodplug/src/fastmix.cpp:X86_Convert32To24()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is based on a patch by @adelva1984 that has been sitting around in the MegaZeux repository for a while. The original bitshifts are obviously wrong and result in 2 of the 3 sample bytes being 0 or 0xFF instead of the intended value.