Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: added comparator tests #106

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Test: added comparator tests #106

merged 7 commits into from
Jul 4, 2023

Conversation

KoolTheba
Copy link
Collaborator

@KoolTheba KoolTheba commented Jul 4, 2023 •
edited

Main changes

  • Added fixtures, test ids and tests for comparator
  • Refactored commit data handler for improved legibility
  • Fixed minor issues

Changelog

UlisesGascon
UlisesGascon previously approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@KoolTheba KoolTheba changed the title Feature: tests Test: added comparator tests Jul 4, 2023
@KoolTheba KoolTheba merged commit 142f095 into main Jul 4, 2023
4 checks passed
@UlisesGascon UlisesGascon deleted the feature/tests branch July 4, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KoolTheba @UlisesGascon