Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from config file to environment variables #5

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

LeoColomb
Copy link
Contributor

@LeoColomb LeoColomb commented Apr 4, 2024

While environment variables are not perfect, they are quite easier to manage in a Kubernetes context than a config map, especially for few options.
In that way, the surface of failure is substantially reduced (no file, no description scheme, no runtime dependencies, etc.), and are more intuitive to configure per deployment.

The host private key is still a secret, mounted as a volume to embrace the best security recommendations.

@LeoColomb LeoColomb marked this pull request as ready for review April 4, 2024 17:37
@LeoColomb LeoColomb marked this pull request as draft April 5, 2024 06:54
@Kooper
Copy link
Owner

Kooper commented Apr 5, 2024

I have nothing to object with, lets stick to environment variables for the server configuration to not bother users with config maps

@LeoColomb LeoColomb marked this pull request as ready for review April 5, 2024 11:41
@Kooper Kooper merged commit c9c06c2 into Kooper:main Apr 10, 2024
7 checks passed
@LeoColomb LeoColomb deleted the fix/config branch April 10, 2024 09:42
@LeoColomb
Copy link
Contributor Author

@Kooper Thanks for merging! 🥳
Would it be possible to create a git tag on the repository? The version that fits you the best, e.g., v0.1.0
I expect the GoReleaser action to then push the release notes and the Docker image.

@Kooper
Copy link
Owner

Kooper commented Apr 11, 2024

Well, @LeoColomb, thanks for your contributions! I think the improvements you made are deserving a release, so I'm tagging the proposed version with the alpha pre-release version.
I've generated the default description for now

@Kooper
Copy link
Owner

Kooper commented Apr 11, 2024

BTW the release pipeline has been failed with the "error=docker images: failed to publish artifacts: failed to push ghcr.io/kooper/ingressh:v0.1.0-alpha after 0 tries: failed to push ghcr.io/kooper/ingressh:v0.1.0-alpha: exit status 1: unauthorized: unauthenticated: User cannot be authenticated with the token provided."

So I think I should somehow setup access token to write to ghcr.io 🤔
UPD It looks like package must first be connected with the code repository. However I'm unable to find any control to create a package in the GH interface yet

@LeoColomb
Copy link
Contributor Author

So I think I should somehow setup access token to write to ghcr.io

Oy, no, it's me again forgetting the basics. Let me submit another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants