Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with version number generation #2

Open
Thermi opened this issue Dec 27, 2020 · 0 comments
Open

Issue with version number generation #2

Thermi opened this issue Dec 27, 2020 · 0 comments

Comments

@Thermi
Copy link

Thermi commented Dec 27, 2020

Hi,

The code generating the version number from the git repo is broken in a special way:
Even if the libkcoidc source code is not a git repo itself but is in a subdirectory of one, it generates the version number based on that one. Even if the .version file is created before configure is run, it does that. If that git repo is "dirty" it appends the -dirty suffix to the version number. When it then generates the pkg-config file, its Version field contains a version number with the -dirty suffix, which is not good, because the best practice for it is to only contain a decimal and dotted version number, without alphabetical characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant