cbNameLater

[Sigma88]

I had some time to play around with displayName and I came to the conclusion that it can completely replace cbNameLater.

I propose, for backwards compatibility's sake, to leave cbNameLater as a valid Kopernicus input, but having it just change displayName internally.

I will prepare a pull-request, in the meantime if anyone has objections to this, you can comment here

[Sigma88]

pinging here some people I know use the feature:

@NathanKell (RSS)
@GregroxMun (various)
@Galileo88 / @OhioBob (GPP)

the only downside to this change would be with science definition.

right now, using cbNameLater, science defs need to point at the final name, so

EarthSrfLanded = def

instead of

KerbinSrfLanded = def

switching to displayName, for sience defs you would need to use the "name" regardless of what the displayName is.

so all packs that rename the homeplanet should use

KerbinSrfLanded = def

I think this is a small price to pay since displayName seems to be a much more stable option over cbNameLater.

I've already moved on to use displayName in my mods that were using cbNameLater and I've yet to see any downsides.

edit:

if you are worried about getting unwanted science definitions that target kerbin, you can always take a look at my mod Sigma SciDefRenamer which allows you to use a different name for your science defs like:

RSSKerbinSrfLanded = def

then having my mod delete all science definitions that target "Kerbin" and then replace all "RSSKerbin" with "Kerbin" so that you are sure only your science defs apply to Earth (same goes for all other planet packs I mentioned earlier)

[StollD]

I don't want to remove it, at least not now.

The reason is simple: It works. And displayName works too, so the planet makers can decide when they will switch. The only thing we should do is to say, that cbNameLater can be removed in every update and that the planet makers should switch to displayName as soon as possible.

[Sigma88]

that's cool by me, I've already switched anyways

[NathanKell]

Thing is I would like to keep Earth called Earth in data as well as visually, so I'd like to stay on cbnamelater

…

On May 29, 2017 9:15 AM, "Sigma88" ***@***.***> wrote: that's cool by me, I've already switched anyways — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#177 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE5-InvrGpMeCR2um-6RjQ2TvfcOrAzcks5r-u8qgaJpZM4NpEGA> .

[Sigma88]

@NathanKell is there some places where the real name of the planet could come up?

[Sigma88]

I'd say there's enough interest to keep cbNameLater, so I'll just close the issue

[NathanKell]

Sorry I didn't get back (saw you closed it) but did want to state for the record that even if the only place it's used is the save file, that's still very useful when trying to debug a save. But it's very possible that there's legacy code in mods, even if not in KSP itself, where name not displayname is used.

[Sigma88]

yes that's what I was thinking.
I don't really care about that, mods can always be updated, but I can understand how for a mod like RSS you might want to avoid go through the changes

[NathanKell]

Yep, also has a worrying effect on saves without a conversion plugin I think (due to science records as you say, and also body progress trees).