Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kopernicus not setting biome displayname #183

Closed
DMagic1 opened this issue Jun 16, 2017 · 1 comment
Closed

Kopernicus not setting biome displayname #183

DMagic1 opened this issue Jun 16, 2017 · 1 comment

Comments

@DMagic1
Copy link

DMagic1 commented Jun 16, 2017

In KSP 1.3 biomes now have a localized name field.

CBAttributeMapSO.MapAttribute.displayName

This is read for science results among other things.

The BiomeLoader class doesn't appear to handle this, only setting the regular name field.

An option to set a display name would be good for localization, but it should at least set the display name using the regular name field by default.
Sigma88 added a commit that referenced this issue Jun 17, 2017
@Sigma88
attempt to solve #183
9d062a8
StollD pushed a commit that referenced this issue Jun 20, 2017
Merge pull request #184 from Kopernicus/biome-displayName
70e145c 
attempt to solve #183
@StollD
Copy link
Member

StollD commented Jun 30, 2017

Done by @Sigma88

@StollD StollD closed this as completed Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DMagic1 @StollD