Ring shader fixes and enhancements #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only set sun radius once rather than every update - NewShader: Use mesh's texture coordinates - NewShader: Use material color - NewShader: Enable z-buffer - Rewrite shader compilation instructions
- NewShader: Cull back faces - NewShader: Add innerShadeTexture property - NewShader: Add innerShadeTiles property - NewShader: Add innerShadeRotationPeriod property - Add new type of shadow based on the inner shade texture properties - Move sun radius set back to where it was
|
Looks like I didn't see this. Looks good, thank you! |
StollD
pushed a commit
that referenced
this pull request
Aug 27, 2017
|
Cool! |
|
Sure, feel free to update them. I will probably just forget it when I make the next release.
|
HebaruSan
added a commit
to HebaruSan/Kopernicus
that referenced
this pull request
Aug 27, 2017
|
Sounds good, I submitted them in: |
StollD
pushed a commit
that referenced
this pull request
Aug 27, 2017
Update shaders with changes from #206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the configuration of the "new shader" more consistent with the old shader, so old rings can be updated to use it without modification:
colorproperty (required for tinted rings as in the green JoolRings example)Then a new concept of "inner shade" is added to the "thick" rings. This is a texture that can be used to cast independently mobile shadows on the inner face of a thick ring.
After these changes, I'm able to configure a real-scale Ringworld complete with functional shadow squares: