Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BlockingFilter #659

Closed
margaretha opened this issue Aug 31, 2023 · 2 comments
Closed

Fix BlockingFilter #659

margaretha opened this issue Aug 31, 2023 · 2 comments
Milestone
0.72

Comments

@margaretha
Copy link
Contributor

margaretha commented Aug 31, 2023 •
edited

BlockingFilter implements ContainerRequestFilter where in KorAP uses SecurityContext to check if a user logged in or not.

After migrating to JakartaEE, securityContext.getUserPrincipal() becomes null. The Principal comes from org.glassfish.grizzly.http.server.Request in the test environment.
@margaretha margaretha added this to the 0.72 milestone Aug 31, 2023
@margaretha
Copy link
Contributor Author

The remaining javax.annotation.Priority had caused the problem.

idsgerrit pushed a commit that referenced this issue Sep 1, 2023
@margaretha
Fixed BlockingFilter (#659)
75d654c 
Replaced javax.annotation.Priority with jakarta.annotation.Priority
(#648)

Change-Id: I61ebaceeeeefe116cf9bd48dfd668ce8c17144b2
idsgerrit pushed a commit that referenced this issue Sep 1, 2023
@margaretha
Fixed BlockingFilter (#659)
db5da37 
Replaced javax.annotation.Priority with jakarta.annotation.Priority
(#648)

Change-Id: I61ebaceeeeefe116cf9bd48dfd668ce8c17144b2
@margaretha
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.72
Development

No branches or pull requests
1 participant
@margaretha