Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/meta/totalResults in the API search response should remain a number #668

Closed
kupietz opened this issue Sep 18, 2023 · 3 comments
Closed

Comments

@kupietz
Copy link
Member

kupietz commented Sep 18, 2023

but now returns a string:

 $ GET 'https://korap.ids-mannheim.de/instance/test/api/v1.0/search?q=Ameisenplage&ql=poliqarp' | json_pp | grep totalResults
      "totalResults" : "13",
@notesjor
Copy link

Ja, aber die Rückgabe eines einzelnen numerischen Werts kann Probleme bereiten. Gerade dann, wenn man die Rückgabe als JSON parst - was beim Rest der Rückgaben der KorapAPI der Fall ist. Ich würde das nicht ändern.

@kupietz
Copy link
Member Author

kupietz commented Sep 19, 2023

Ja, aber die Rückgabe eines einzelnen numerischen Werts kann Probleme bereiten. Gerade dann, wenn man die Rückgabe als JSON parst - was beim Rest der Rückgaben der KorapAPI der Fall ist. Ich würde das nicht ändern.

Ja, es geht genau darum, dass sich gegenüber der Version, die aktuell im Produktionsbetrieb ist, nichts ändert.

idsgerrit pushed a commit to KorAP/RKorAPClient that referenced this issue Mar 11, 2024
See:
KorAP/Kustvakt#668
which was fixed in
https://korap.ids-mannheim.de/gerrit/c/KorAP/Kustvakt/+/7526,but not yet
rolled out in all KorAP instances

Change-Id: I64c61c35734472e52f6875c35b6e587fb252c4c1
idsgerrit pushed a commit to KorAP/RKorAPClient that referenced this issue Mar 11, 2024
See:
KorAP/Kustvakt#668
which was fixed in
https://korap.ids-mannheim.de/gerrit/c/KorAP/Kustvakt/+/7526 , but not
yet rolled out in all KorAP instances

Change-Id: I64c61c35734472e52f6875c35b6e587fb252c4c1
idsgerrit pushed a commit to KorAP/RKorAPClient that referenced this issue Mar 11, 2024
See:
KorAP/Kustvakt#668
which was fixed in
https://korap.ids-mannheim.de/gerrit/c/KorAP/Kustvakt/+/7526 , but not
yet rolled out in all KorAP instances

Change-Id: I64c61c35734472e52f6875c35b6e587fb252c4c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants