Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Holes Enchantment not working cross other mods #4

Closed
litjohn50 opened this issue Sep 6, 2018 · 5 comments
Closed

Big Holes Enchantment not working cross other mods #4

litjohn50 opened this issue Sep 6, 2018 · 5 comments
Labels
invalid This doesn't seem right

Comments

@litjohn50
Copy link

So Mining with a diamond pickaxe Big holes does not mine 3x3.

Mining stone: Work perfectly: https://gyazo.com/c0c8fd5db4616210a4e7c0efb8832261

Mining copper ore (not enough roofs): https://gyazo.com/423279f3c54d44acaf0042618f2d52c5
Doesn't work.

Mining stones (Terra): https://gyazo.com/b9bb5476167c89e6cd4246213a161340
Doesn't work, and their stone is oredicted in case wondering.

I am not shifting at all in any of these videos.

@KorDum KorDum added the bug Something isn't working label Sep 6, 2018
@KorDum
Copy link
Owner

KorDum commented Sep 6, 2018

Thanks for feedback!
Can you tell me version of NotEnoughScaffold?

@KorDum
Copy link
Owner

KorDum commented Sep 7, 2018

I can not reproduce bug with latest version of Not Enough Roofs mod.
But i can reproduce with Terra. Hm. This behavior occurs because blocks don't have a required tool to harvest it.

https://github.com/KorDum/NotEnoughScaffold/blob/master/src/main/java/alhetta/notenoughscaffold/handler/EnchantmentEventHandler.java#L108
returns null for Soapstone for example.

@litjohn50
Copy link
Author

version is 1.8

@xAlicatt
Copy link

xAlicatt commented Nov 3, 2018

Is this actually a bug or is it user error? If it's a bug, is it fixed yet or in the works? I'm wanting to add this mod to my pack, but not if this portion is broken. I guess I could just disable the enchanting part if it doesn't work as expected until it is fixed though. ¯\_(ツ)_/¯

@KorDum
Copy link
Owner

KorDum commented Nov 4, 2018

It is bug from Terra mod. Harvest tool is not set for block from Terra.

@KorDum KorDum added invalid This doesn't seem right and removed bug Something isn't working labels Nov 4, 2018
@KorDum KorDum closed this as completed Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants