Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script improvements and documentation #17

Merged
merged 5 commits into from
Jan 3, 2018
Merged

Conversation

robinwyss
Copy link
Contributor

The PR contains the following changes

  • Added the -d flag to the the start script, this way source maps are generated
  • Copy .gitignore along with the rest of the files instead of downloading it from github, this also makes the script independent of the repo. Was there a specific reason to download the file github?
  • Added some comments in the script to make it easier to read and understand

@robinwyss robinwyss changed the title script improvements and documents script improvements and documentation Dec 15, 2017
@Kornil
Copy link
Owner

Kornil commented Dec 30, 2017

Hi @robinwyss !
Thanks for your patience, as I was travelling in the last period your PR kinda slipped my mind.

Now on the code:
comments are an awesome first iteration! Really like the initiative and I would merge it if there wasn't the second part, the .gitignore copy instead of fetch.

.gitignore is not copied over in some OSes when you install the project globally with npm install -g simple-react-app so I could not copy it over like all the other files.
I could not replicate the bug myself on my OS (linux manjaro) but on a virtual mac the bug was there, everything is documented here #12

If you can remove the.gitignore change I will merge the PR. If you want to go the extra mile you can document why the .gitignore works this way ;)

@robinwyss
Copy link
Contributor Author

robinwyss commented Jan 3, 2018

@Kornil thanks for the feedback
I reverted the change to copy the .gitignore locally and added a comment about it in the script.

@Kornil
Copy link
Owner

Kornil commented Jan 3, 2018

Great job, merging!

@Kornil Kornil merged commit 582c5f6 into Kornil:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants