Firedb refactor #477
Merged
Firedb refactor #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refaktorisering med henblik på at hjælpe VSC og andre værktøjer med at
finde rundt i koden selvom den er delt ud på flere forskellige filer.
Den lidt ukonventionelle løsning med imports af funktioner ind i selve
klassen gør det svært for diverse værktøjer at regne ud hvor en given
funktion kommer fra. Det problem er løst ved i stedet at nedarve fra en
række klasser der alle har rod i BaseFireDb. Det vil sige vi får en
nedarvning i stil med
BaseFireDb
FireDbHent FireDbIndset FireDbLuk
FireDb
I takt med at der kommer mere funktionalitet i FireDb kan det flyttes ud
i flere forskellige filer og klasser.
Nødvendigt at angive typen på new_firedb for at F12-funktionen virker i fire.cli koden.
xidus
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gør det muligt at bruge Visual Studio Codes F12 søgefunktion