-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newyerushalmi Code to implement New Yerushalmi Yomi #206
base: master
Are you sure you want to change the base?
Conversation
I was thinking about the <= bug it might be clearer codeto init the daf number to 1 not 0 didn't test this way just was bugging me why it was a problem current way 1st daf is 0 and no such daf |
is kilahim supposed to have 2 yuds? |
@elazarrosenthal , |
Junk removed |
I am not sure if there are many people using the "NEW" yerushalmi dafyomi scedual or if its just an Artscroll thing For most of the tables I generated the code form sources descrbed in my dev direcotry on other branch (see below) Even if you dont want the NEW code you might want to take my Cycle11 test for the original cycle as that is how I found some of the bugs I reported The tables from the java were created from sources https://github.com/elazarrosenthal/zmanim/tree/newyerushalmi_dev since I deleted the file putting readme here I am not sure what names to use for the new scedual README.txt - this file Note: at first I thought that there where just differences in page counts
I opened a spreadsheet and pasted the website csv and Artscroll pdf csv side by side on same spreadsheet |
See Readme in directory new-yerushalmi-dev-notes
contains notes and scripts that should probably be left out of master
Even if you dont want whole code My testing uncoverd 1 bug in existing
YerushalmiYomiCalculator -> public static Daf getDafYomiYerushalmi(JewishCalendar calendar) {
for (int j = 0; j < BLATT_PER_MASSECTA.length; j++) {
should be < not <= (messed up 1st page of new mesechta)