Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interface measurements in the analysis pipeline #330

Merged
merged 4 commits into from
May 24, 2024

Conversation

dingquanyu
Copy link
Collaborator

  1. Fixed the calculation of interface pae values
  2. Now will save the output files from pi_score pipeline in the output directory again.

@dingquanyu dingquanyu linked an issue May 3, 2024 that may be closed by this pull request
@dingquanyu dingquanyu mentioned this pull request May 3, 2024
@dingquanyu
Copy link
Collaborator Author

@jkosinski @DimaMolod Could you take a look at this PR next week? I've run this version of code on Dima's 5 folders and you can take a look at the output csv table.

@jkosinski
Copy link
Collaborator

OK!

@DimaMolod
Copy link
Collaborator

@jkosinski @DimaMolod Could you take a look at this PR next week? I've run this version of code on Dima's 5 folders and you can take a look at the output csv table.

@dingquanyu I am not sure I will have time to look into the code, but at first glance (I looked at the best and the worst cases), the numbers now look more reasonable

@dingquanyu dingquanyu merged commit 9d75f23 into main May 24, 2024
8 checks passed
@dingquanyu dingquanyu deleted the fix-interface-analysis branch May 24, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pi-score outputs
3 participants